Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(nginx): add option to easy manage HEADERS (make it possible to set HSTS) #630

Merged
merged 1 commit into from
Oct 22, 2024
Merged

fix(nginx): add option to easy manage HEADERS (make it possible to set HSTS) #630

merged 1 commit into from
Oct 22, 2024

Conversation

wrenix
Copy link
Collaborator

@wrenix wrenix commented Sep 19, 2024 •
edited
Loading

Description of the change

Benefits

Possible drawbacks

Applicable issues

  • fixes #

Additional information

Checklist

@wrenix wrenix requested a review from jessebot September 19, 2024 18:03
@wrenix wrenix self-assigned this Sep 19, 2024
@wrenix wrenix force-pushed the fix/hsts-on-nginx branch 2 times, most recently from 51f27a8 to 8d5e6e7 Compare September 19, 2024 18:05
provokateurin
provokateurin previously requested changes Sep 19, 2024
View reviewed changes
charts/nextcloud/values.yaml Outdated Show resolved Hide resolved
jessebot
jessebot requested changes Sep 20, 2024
View reviewed changes
Copy link
Collaborator

@jessebot jessebot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please also update the README.md?

@wrenix
Copy link
Collaborator Author

wrenix commented Sep 21, 2024

i move all headers to values.yaml -> docs are coming

@wrenix wrenix force-pushed the fix/hsts-on-nginx branch 2 times, most recently from f4396a1 to e6c8079 Compare September 21, 2024 10:11
@jessebot jessebot mentioned this pull request Sep 25, 2024
Closed
@wrenix wrenix requested a review from jessebot September 30, 2024 18:13
@wrenix wrenix force-pushed the fix/hsts-on-nginx branch from e6c8079 to 02a58b8 Compare October 11, 2024 22:10
@wrenix
Copy link
Collaborator Author

wrenix commented Oct 11, 2024

ping @jessebot

@wrenix wrenix changed the title fix(nginx): add option to easy set HSTS fix(nginx): add option to easy manage HEADERS (make it possible to set HSTS) Oct 22, 2024
@wrenix wrenix force-pushed the fix/hsts-on-nginx branch from 02a58b8 to 5e8b9b5 Compare October 22, 2024 08:26
@wrenix wrenix requested a review from jessebot October 22, 2024 08:27
@wrenix wrenix force-pushed the fix/hsts-on-nginx branch from 5e8b9b5 to 06726fe Compare October 22, 2024 08:29
@jessebot
Copy link
Collaborator

@wrenix looks good to me, feel free to merge :)

@jessebot jessebot dismissed provokateurin’s stale review October 22, 2024 09:19

this has been addressed and fixed :)

@wrenix wrenix merged commit 671f4c2 into nextcloud:main Oct 22, 2024
9 checks passed
@wrenix wrenix deleted the fix/hsts-on-nginx branch October 22, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jessebot jessebot jessebot approved these changes

@provokateurin provokateurin Awaiting requested review from provokateurin

Assignees

@wrenix wrenix

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wrenix @jessebot @provokateurin